Skip to content

Ai ddl improvements#1776

Merged
lyubov-voloshko merged 3 commits into
mainfrom
ai-ddl-improvements
May 15, 2026
Merged

Ai ddl improvements#1776
lyubov-voloshko merged 3 commits into
mainfrom
ai-ddl-improvements

Conversation

@lyubov-voloshko
Copy link
Copy Markdown
Collaborator

No description provided.

lyubov-voloshko and others added 2 commits May 15, 2026 08:27
…x approve/reject button lifecycle

- Remove outer `!applied()` guard so input is always shown after approval
- Reset `applied` signal when new AI batch arrives to re-enable approve/reject buttons
- Clear batchId on successful approval so pendingBatch() returns null and input reappears
- Disable textarea while AI request is in flight

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 15, 2026 08:54
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Warning

Rate limit exceeded

@lyubov-voloshko has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f3235919-03e0-42a7-834f-dd2daf1e9d39

📥 Commits

Reviewing files that changed from the base of the PR and between 8ca1841 and 5a8c5ad.

📒 Files selected for processing (5)
  • frontend/src/app/components/dashboard/dashboard.component.ts
  • frontend/src/app/components/dashboard/db-tables-data-source.ts
  • frontend/src/app/components/edit-database-schema/edit-database-schema.component.html
  • frontend/src/app/components/edit-database-schema/edit-database-schema.component.ts
  • frontend/src/app/services/tables.service.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ai-ddl-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lyubov-voloshko lyubov-voloshko enabled auto-merge May 15, 2026 08:54
@coderabbitai coderabbitai Bot requested a review from gugu May 15, 2026 08:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the AI schema editing flow so newly applied DDL changes can be reviewed in the dashboard with a cache-bypass flag and continued chat interaction.

Changes:

  • Adds an uncached option through dashboard row loading and table service requests.
  • Adds an uncached=true query param to the schema editor’s “Open tables” link.
  • Keeps the schema editor input available after applying changes and clears completed batch state.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/src/app/services/tables.service.ts Sends _uncached=true to the rows API when requested.
frontend/src/app/components/edit-database-schema/edit-database-schema.component.ts Resets applied state on new AI changes and clears batch state after successful approval.
frontend/src/app/components/edit-database-schema/edit-database-schema.component.html Adds uncached navigation to dashboard and keeps the prompt form visible.
frontend/src/app/components/dashboard/db-tables-data-source.ts Passes the uncached flag from dashboard row requests into the table service.
frontend/src/app/components/dashboard/dashboard.component.ts Reads uncached from query params and forwards it into row loading.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tableName = this.allTables[0]?.table;
}
this.router.navigate([`/dashboard/${this.connectionID}/${tableName}`], { replaceUrl: true });
this.router.navigate([`/dashboard/${this.connectionID}/${tableName}`], { replaceUrl: true, queryParamsHandling: 'preserve' });
@lyubov-voloshko lyubov-voloshko merged commit 2c6f263 into main May 15, 2026
16 checks passed
@lyubov-voloshko lyubov-voloshko deleted the ai-ddl-improvements branch May 15, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants